Conversation
sbc100
force-pushed
the
wasm_bigint
branch
2 times, most recently
from
2484a29 to
b84c9bd
Compare
sbc100
force-pushed
the
wasm_bigint
branch
3 times, most recently
from
834c3bd to
aa256bb
Compare
|
Hm.. it looks like more work is requires to make the binaryen API bigint friendly. @kripken did you take a look at this in the past? |
|
Hmm, no, I don't recall doing that. More generally, my hope is we can move binaryen.js to embind so stuff like this is handled automatically. |
It seems like there are places where the API uses 64-bit stuff and is not expecting it to simply use bigints |
sbc100
force-pushed
the
wasm_bigint
branch
4 times, most recently
from
991158b to
8d03d35
Compare
|
I decided to look into the changes needed to the JS API.. WDYT? |
sbc100
changed the title
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Changes make sense to me, but they are breaking, so please update the changelog.
This flag has been enabled by default in emscripten for a while now so I don't think we need this here anymore. The main user-visible effect of this change is that it makes the `module.i64.const` JS method now simply take a single bigint rather than a pair numbers.
|
Oops, sorry, I didn't realize that would auto-land. Will add a Changelog entry now. |
2 participants
This flag has been enabled by default in emscripten for a while now so I don't think we need this here anymore.
Also remove the
-Wno-experimentalflag which is no longer needed for-sMEMORY64.Also remove
-sMODULARIZEwhich is implied by-sEXPORT_ES6.